From: Marco Trevisan (Treviño) <mail@3v1n0.net>
Date: Mon, 1 Feb 2021 18:39:03 +0000 (+0100)
Subject: authPrompt: Only wiggle the entry on failures coming from the querying service
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~616^2^2~334
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=19c4dce3227a6a9748ed98682914b6b6dede1bd7;p=gnome-shell.git

authPrompt: Only wiggle the entry on failures coming from the querying service

Currently whenever an authentication failure happens we wiggle the
entry, however this may not be related to the service which failed.

For example if the fingerprint authentication failed for whatever reason,
there's no point to wiggle the text input as it's something unrelated to it.

So, only apply the wiggle effect to the entry in case the failure is
coming from the querying service.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1652>
---

diff --git a/js/gdm/authPrompt.js b/js/gdm/authPrompt.js
index 4aba39f36..95f07a6a3 100644
--- a/js/gdm/authPrompt.js
+++ b/js/gdm/authPrompt.js
@@ -279,6 +279,7 @@ var AuthPrompt = GObject.registerClass({
     }
 
     _onVerificationFailed(userVerifier, serviceName, canRetry) {
+        const wasQueryingService = this._queryingService === serviceName;
         this._queryingService = null;
         this.clear();
 
@@ -286,7 +287,8 @@ var AuthPrompt = GObject.registerClass({
         this.setActorInDefaultButtonWell(null);
         this.verificationStatus = AuthPromptStatus.VERIFICATION_FAILED;
 
-        Util.wiggle(this._entry);
+        if (wasQueryingService)
+            Util.wiggle(this._entry);
     }
 
     _onVerificationComplete() {